Fix generated flow type rule w readonly/aliased types #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsavona
commented
Jun 3, 2019
src/rule-generated-flow-types.js
Outdated
| .filter(maybeObjectType => { | ||
| // GenericTypeAnnotation may not map to an object type | ||
| return maybeObjectType && | ||
| maybeObjectType.type === 'ObjectTypeAnnotation'; |
There was a problem hiding this comment.
The lack of a filter here meant a non-ObjectTypeAnnotation could be passed below
| } | ||
| // otherwise report an error at the first object | ||
| validateObjectTypeAnnotation( |
There was a problem hiding this comment.
...the invalid value would have passed here
| if (lintResults.some(result => result)) { | ||
| // One of the intersected objects has it right | ||
| break; | ||
| for (const objectType of objectTypes) { |
There was a problem hiding this comment.
change to a loop to exit early once we know there's a valid type
mrtnzlml
reviewed
Jun 4, 2019
| errors: [ | ||
| { | ||
| message: | ||
| '`user` is not declared in the `props` of the React component or it is not marked with the generated flow type `MyComponent_user`. ' + |
There was a problem hiding this comment.
Hi @josephsavona! Could you please check this issue? #59 I think it's related to what you wrote here since seems like it doesn't work as expected (even though in this case it's probably fine).
There was a problem hiding this comment.
That looks like a separate issue. The issue here is just that we’re not following type aliases and not unwrapping readonly. Happy to accept PRs for #59 though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a fatal where
validateObjectTypeAnnotation()fatals when passed an unexpected value (whenpropTypeisn't anObjectTypeAnnotationas expected). This can occur when GenericTypeAnnotations aren't filtered later in the file. The simple fix was to just filter out non-ObjectTypeAnnotation values, but I noticed this bug because of an example involving$ReadOnly<Props>. I realized we aren't unwrapping ReadOnly values, and also aren't fully resolving aliases, so I implemented support for those and then filtered out non-object types only afterwards.