Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table namespaces #256

Open
wants to merge 2 commits into
base: v1.x
Choose a base branch
from
Open

Conversation

izica
Copy link

@izica izica commented Mar 29, 2023

Make it possible to create a nested (unlimited depth) structure of models.

For example:

Tables:
users
task_tracker__task

Output models folder structure:

  • Base
    • User.php
  • User.php
  • TaskTracker
    • Base
      • Task.php
    • Task.php

namespace in Task.php: namespace App\Models\TaskTracker;

Copy link
Contributor

@finiteinfinity finiteinfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach, but this introduces a significant breaking change. Ideally, this should be opt-in via a new config value rather than enabled by default. Also, the table separator should be configurable too, rather than hard-coded to fit your specific use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants