Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scenes): replace eval with new Function #3

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

remarkablemark
Copy link
Member

@remarkablemark remarkablemark commented May 28, 2024

What is the motivation for this pull request?

Script is not eval-ed properly as add is using the document context rather than the window context so sprites are not rendering

Checklist:

@remarkablemark remarkablemark added the bug Something isn't working label May 28, 2024
@remarkablemark remarkablemark self-assigned this May 28, 2024
Copy link

cloudflare-workers-and-pages bot commented May 28, 2024

Deploying code-arcade with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3bf1cf8
Status: ✅  Deploy successful!
Preview URL: https://30e59d03.code-arcade.pages.dev
Branch Preview URL: https://fix-game.code-arcade.pages.dev

View logs

@remarkablemark remarkablemark force-pushed the fix/game branch 2 times, most recently from af61549 to c369d2d Compare May 28, 2024 06:26
@remarkablemark remarkablemark changed the title fix(scenes): eval script in game fix(scenes): replace eval with new Function May 28, 2024
@remarkablemark remarkablemark merged commit c6daa59 into master May 28, 2024
6 checks passed
@remarkablemark remarkablemark deleted the fix/game branch May 28, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant