Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate all typedefs into their own JSDoc blocks #878

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Separate all typedefs into their own JSDoc blocks #878

merged 1 commit into from
Jan 2, 2025

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

This change separates all typedefs into their own JSDoc blocks. Having them in the same block, can be problematic sometimes. For example when they contain @template tags.

@remcohaszing
Separate all typedefs into their own JSDoc blocks
c582e3b 
Having them in the same block, can be problematic sometimes. For
example when they contain `@template` tags.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 20, 2024
@remcohaszing remcohaszing added 🏡 area/internal This affects the hidden internals 🦋 type/enhancement This is great to have labels Dec 20, 2024
ChristianMurphy
ChristianMurphy approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong feelings either way, I'm fine with this change, though I think things currently work without it too.

@remcohaszing remcohaszing mentioned this pull request Jan 2, 2025
Merged
6 tasks
@remcohaszing remcohaszing merged commit 27d3949 into main Jan 2, 2025
7 checks passed
@remcohaszing remcohaszing deleted the separate-typedef-blocks branch January 2, 2025 11:42
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing added 🙆 yes/confirmed This is confirmed and ready to be worked on 👍 phase/yes Post is accepted and can be worked on labels Jan 2, 2025
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 2, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 💪 phase/solved Post is done label Jan 2, 2025
@github-actions github-actions bot removed 👍 phase/yes Post is accepted and can be worked on 🙆 yes/confirmed This is confirmed and ready to be worked on labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
🏡 area/internal This affects the hidden internals 💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remcohaszing @ChristianMurphy @wooorm