Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OAE assumptions to default for SSP2-EcBudg400 #1884

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

laurinks
Copy link
Contributor

@laurinks laurinks commented Nov 15, 2024

Purpose of this PR

Setting OAE assumptions for newly added SSP2-EcBudg400 to default parameters (see Issue 372). This way, the two parameter columns for OAE can be removed from scenario_config.csv

Type of change

  • Change of newly added default scenario. Scenario had not been part of earlier validation.

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@laurinks
Copy link
Contributor Author

File comparison: /p/projects/rd3mod/github/repos/remindmodel/remind/develop/config/scenario_config.csv -> ./config/scenario_config.csv
Columns deleted: cm_33_OAE_eff, cm_33_OAE_scen
Columns added:   -
Renamed columns: -
Renamed rows:    -

Changes in the scenarios:

$allwarnings
NULL

@laurinks laurinks merged commit 87812e7 into remindmodel:develop Nov 15, 2024
2 checks passed
@laurinks laurinks deleted the scenario-config branch November 15, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants