Fix error sanitization test

remix-run · Apr 8, 2024 · 1323380 · 1323380
1 parent d443999
commit 1323380
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/integration/playwright.config.ts b/integration/playwright.config.ts
@@ -6,7 +6,6 @@ const config: PlaywrightTestConfig = {
   testMatch: ["**/*-test.ts"],
   // TODO: Temporary!  Remove from this list as we get each suite passing
   testIgnore: [
-    "**/error-sanitization-test.ts",
     "**/file-uploads-test.ts",
     "**/vite-basename-test.ts",
     "**/vite-build-test.ts",

diff --git a/packages/react-router-dom/index.tsx b/packages/react-router-dom/index.tsx
@@ -595,9 +595,7 @@ function deserializeErrors(
           try {
             // @ts-expect-error
             let error = new ErrorConstructor(val.message);
-            // Wipe away the client-side stack trace.  Nothing to fill it in with
-            // because we don't serialize SSR stack traces for security reasons
-            error.stack = "";
+            error.stack = val.stack;
             serialized[key] = error;
           } catch (e) {
             // no-op - fall through and create a normal Error
@@ -607,9 +605,7 @@ function deserializeErrors(
 
       if (serialized[key] == null) {
         let error = new Error(val.message);
-        // Wipe away the client-side stack trace.  Nothing to fill it in with
-        // because we don't serialize SSR stack traces for security reasons
-        error.stack = "";
+        error.stack = val.stack;
         serialized[key] = error;
       }
     } else {