Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(routers/create-browser-router): fix docs-info links #10726

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

sbolel
Copy link
Contributor

@sbolel sbolel commented Jul 22, 2023

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2023

⚠️ No Changeset found

Latest commit: 02ff490

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 22, 2023

Hi @sbolel,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@sbolel sbolel force-pushed the docs/routers/create-browser-router branch from f856897 to 02ff490 Compare July 22, 2023 09:59
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 22, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Jul 22, 2023

Thanks!

@timdorr timdorr merged commit 028129c into remix-run:main Jul 22, 2023
1 check passed
@sbolel
Copy link
Contributor Author

sbolel commented Jul 23, 2023

@timdorr my pleasure, thanks for the quick review!

@sbolel sbolel deleted the docs/routers/create-browser-router branch July 23, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: markdown links in docs-info block are not rendered
2 participants