Fix error-sanitization-test

[markdalgleish]

Turns out the logic differed slightly between react-router-dom and @remix-run/react and that Remix serializes stack traces in development mode, so we need to ensure that stack traces are picked up when deserializing errors.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c51db03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[brophdawg11]

lol I was super confused for a bit - since we shouldn't be using this "built-in" hydration logic in Remix since we do our own hydration via window.__remixContext. This is used to automatically hydrate from StaticRouterProvider's window.__staticRouterHydrationData - but we specifically pass hydrate=false in the Remix SSR use case.

Turns out we're just using the wrong implementation since we brought the Remix code over. There's a dup version of this method in ssr/errors.ts that preserves the stack that we're not implementing since it found a local function with the same name.

The original reason for automatically clearing stack traces is that it felt safer than assuming any DIY-SSR setups would always be stripping them on the server like Remix does so it prevented any accidental leakage of SSR stack traces. Including the in dev-only mode felt like something advanced users could achieve via manual hydration.

I think for now we can just de-dup them and maybe add a param to preserve the stack trace that we send from the Remix usage in RouterProvider and continue stripping in the RR case (parseHydrationData).

I am also pretty sure the Remix usage can go away in v7 with single fetch but would need to look a bit deeper into that.

[markdalgleish]

Pairing with @pcattori, we've opted to go with this to keep things moving:

error.stack = process.env.NODE_ENV === "development" ? val.stack : "";

Deduping feels like a larger task given the current structure so I've left that for now.