Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log error when doc generation fail #250

Merged
merged 1 commit into from
Apr 5, 2024
Merged

log error when doc generation fail #250

merged 1 commit into from
Apr 5, 2024

Conversation

kandros
Copy link
Contributor

@kandros kandros commented Apr 4, 2024

I had a hard time working on #243 due to missing logs.

This made understanding what was going easier

@brookslybrand
Copy link
Contributor

I ran into this too but was too lazy to fix, thank you @kandros!

I'll merge this and #248 tomorrow. We're currently investigating a memory leak. We believe we've caught it, but want to avoid touching the site until tomorrow to make sure.

@brookslybrand
Copy link
Contributor

Thanks for looking into #243, that one seems pretty tricky but @brophdawg11 will be very happy if you crack it

@brookslybrand brookslybrand merged commit 617ede6 into remix-run:main Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brookslybrand brookslybrand brookslybrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kandros @brookslybrand