Handle zip traversal vulnerability MobileChromeApps#92

remoorejr · Feb 12, 2022 · ab9ff92 · ab9ff92
1 parent 977b57d
commit ab9ff92
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/android/Zip.java b/src/android/Zip.java
@@ -126,6 +126,13 @@ private void unzipSync(CordovaArgs args, CallbackContext callbackContext) {
                    dir.mkdirs();
                 } else {
                     File file = new File(outputDirectory + compressedName);
+                    String canonicalPath = file.getCanonicalPath();
+                     if (!canonicalPath.startsWith(outputDirectory)) {
+                         String errorMessage = "Zip traversal security error";
+                         callbackContext.error(errorMessage);
+                         Log.e(LOG_TAG, errorMessage);
+                         return;
+                     }
                     file.getParentFile().mkdirs();
                     if(file.exists() || file.createNewFile()){
                         Log.w("Zip", "extracting: " + file.getPath());