[CN] Properly define/select HTML output menu bar elements #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe CN's state HTML output intends to show only one information "block" (the information unit consisting of "Available resources", "Terms", and "Constraints" sections) when a given "snapshot" (the information window that users move forward and backward with the "first"/"prev"/"next"/"last" buttons) is in view. However, at the moment, all such blocks are displayed at once when a state file is first opened.
This PR solves this problem by correctly defining the JavaScript
menuvariable. Its erroneous definition, and a subsequent attempt to index it, causes initialization (via the functioninit) to abort early, before it can hide the rest of the information blocks.