Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CN-Test-Gen] Purely unfolding implementation #386

Merged
merged 14 commits into from
Jul 16, 2024

Conversation

ZippeyKeys12
Copy link
Collaborator

Add an implementation of test generation.

This version generates Google Test harnesses with RapidCheck generators, one per path through the precondition.
It unfolds recursive predicates up to the specified max depth.

I still have to add some tests for CI.

@ZippeyKeys12 ZippeyKeys12 requested a review from dc-mak July 15, 2024 19:42
Copy link
Contributor

@dc-mak dc-mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking reasonable, some minor suggestions. I know some steps for the CI are a pain to add but a few things in CI will make everyone's development process smoother.

backend/cn/main.ml Outdated Show resolved Hide resolved
backend/cn/main.ml Show resolved Hide resolved
backend/cn/testGeneration.ml Show resolved Hide resolved
backend/cn/testGeneration.ml Outdated Show resolved Hide resolved
backend/cn/testGeneration.mli Outdated Show resolved Hide resolved
backend/cn/testGeneration.ml Outdated Show resolved Hide resolved
backend/cn/testGeneration.ml Outdated Show resolved Hide resolved
backend/cn/testGeneration.ml Outdated Show resolved Hide resolved
backend/cn/main.ml Outdated Show resolved Hide resolved
Copy link
Contributor

@dc-mak dc-mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, though I would like to see the changes requested in the follow-up PR (CI, subcommands, rename car to carrier, and a more explanatory file explainer).

backend/cn/testGeneration.ml Outdated Show resolved Hide resolved
backend/cn/testGeneration.ml Outdated Show resolved Hide resolved
@ZippeyKeys12 ZippeyKeys12 marked this pull request as ready for review July 16, 2024 14:09
backend/cn/testGeneration.ml Outdated Show resolved Hide resolved
@dc-mak dc-mak merged commit 851480e into rems-project:master Jul 16, 2024
1 check passed
@dc-mak
Copy link
Contributor

dc-mak commented Jul 16, 2024

Ah damnit the squashed commit message didn't include "This version generates Google Test harnesses with RapidCheck generators, one per path through the precondition. It unfolds recursive predicates up to the specified max depth." which would have been a better summary than what I wrote. Oh well. Next time I'll just ask you to squash it instead.

@ZippeyKeys12 ZippeyKeys12 deleted the cn-test-gen-rebase branch July 16, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants