-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CN-Test-Gen] Purely unfolding implementation #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking reasonable, some minor suggestions. I know some steps for the CI are a pain to add but a few things in CI will make everyone's development process smoother.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, though I would like to see the changes requested in the follow-up PR (CI, subcommands, rename car
to carrier
, and a more explanatory file explainer).
Ah damnit the squashed commit message didn't include "This version generates Google Test harnesses with RapidCheck generators, one per path through the precondition. It unfolds recursive predicates up to the specified max depth." which would have been a better summary than what I wrote. Oh well. Next time I'll just ask you to squash it instead. |
Add an implementation of test generation.
This version generates Google Test harnesses with RapidCheck generators, one per path through the precondition.
It unfolds recursive predicates up to the specified max depth.
I still have to add some tests for CI.