CN: Tidy up run-cn.sh #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two tests which tested for sequencing behaviour which was present previously but is now absent, and one test for a bug. These cases fit better in the cn-tutorial repo and so have been moved there.
dc-mak
force-pushed
the
strengthen-cn-test-script
branch
from
49253c0 to
221b340
Compare
The priniting is now in line with other CI test scripts, and run through shellcheck to check for mistakes. An oddity is that the failing tests could reflect either exit code 1 or 2, and passing arrays in bash is a bit tricky, but this all seems to work.
dc-mak
force-pushed
the
strengthen-cn-test-script
branch
from
d9dc5ff to
612f425
Compare
dc-mak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#394 added subcommands, but the CN CI test script (
tests/cn/run-cn.sh) didn't haveset -e. As such, multiple errors went unnoticed such as the a badfindcommand and acn: unknown commanderror.d9ab081 fixed the first error, and this commit is fixing the second one.