Fixes #435 and #395: SMT backend crashes #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #435: We have to declare structs in dependency order. This fixes the dependency checker, to account for the fact that fields may contain
Mapwhich contains structs. This happens when a struct field contains and array.Fix #395: These are the same changes as in PR #397, but adapted to the new format. To fix this we have to expand
lets in models returned by the solved because it would appear Z3 will sometimes generate them. For the moment we assume that there are no other binders in values., so we just do simple substitution. See comment on
on_let.