Translate FunctionNoParams as a function without parameters. #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kayvan says there's an issue in Cerberus' frontend: Cerberus should've handled FunctionNoParams – which really is different from a function with empty parameter list – before this even gets to CN. In the absence of that, this is a good workaround. |
cp526
reviewed
Aug 5, 2024
|
|
||
| (* The meaning of a function with no parameters depends on the version of C, | ||
| but here we treat it as if it really has no parameter (i.e., like `void`) | ||
| which is what more recent versions of the standard do. *) |
There was a problem hiding this comment.
(As below, this is ok as a workaround, but FunctionNoParams has to be treated specially, in the Cerberus frontend before CN.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438.
When this is merged, we should also merge PR #68 in the tutorial repo to fix the tests.