Add missing bits for supporting default in executable specs.
#814
+30
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #813. The changes are: * Replace the `todo` exception, with a call to the relevant `default` function. * Remember to add the records from `default` to the record map. Note: some future refactoring could be useful, but is not pressing, to factor out common stuff for calling `default` functions.
|
This works on the instances of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #813. The changes are:
todoexception, with a call to the relevantdefaultfunction.defaultto the record map.Note: some future refactoring could be useful, but is not pressing, to factor out common stuff for calling
defaultfunctions.Fixes #714. This also fixes an issue in #714 where we were missing some braces. This should have been a separate PR but I accidentally pushed it here, and the change is sufficiently small that I felt it is not worth doing surgery on the repo to fix.