Remove some predict call duplication #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorickvP
changed the title
daanelson
reviewed
Nov 1, 2024
| @@ -324,6 +318,10 @@ def base_predict( | |||
| torch_device = torch.device("cuda") | |||
| init_image = None | |||
|
|
|||
| if not seed: | |||
There was a problem hiding this comment.
hmm. fp8 predict does come up with a seed, but there's value in logging the seed s.t. the user can see it for subsequent predictions.
There was a problem hiding this comment.
ah jk it's there isn't it. fair enough, this'll work.
daanelson
force-pushed
the
yorickvp/unify-seeds
branch
from
0aced18
to
0ad7832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fp8_predictalready comes up with a seed, makebase_predictalso do this so they're compatiblefp8_predict/base_predictusage in lora predictors (it didn't take anyaspect_ratioargument)