-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use python slim instead of Cuda base image #1205
Conversation
Signed-off-by: technillogue <[email protected]>
Signed-off-by: technillogue <[email protected]>
Signed-off-by: technillogue <[email protected]>
Signed-off-by: Mattt Zmuda <[email protected]>
Defaulting Defaulting to This is tricky... We could improve those percentages by magically setting Unrelated, but we've also had people ask to use custom base images. I'm not sure if we should encourage that since it most likely creates even harder-to-debug errors. |
@technillogue Thanks so much for putting this together. I'm encouraged by how far we can get by moving away from CUDA dev base images. I originally imagined this as a build flag ( Expanding on what @andreasjansson said, and following up on our conversation yesterday, I think we should start by implementing this as an opt-in feature. That solves an immediate need we have, and gives us a good opportunity to continue validating this functionality without the risk of breaking existing Cog models. At the same time, this should be a big improvement for a majority of users, and it'd be nice to migrate everyone to this sooner than later. I wrote up an idea for how we could solve that here: #1207 |
mattt/use-cuda-base-image-flag looks really good, I would be really happy to have that while we figure out the right way to handle #1207. I hadn't thought about what to do with the Like we discussed, we'd like to also support custom dockerfiles that we add labels to, but not custom base images that might not have apt. |
Could this be detected automatically? Andreas hints at a hard to debug error message. Could we automatically detect that error message and hint at the solution? I like the idea of trying to do as much automatically as possible, then giving users a way to bail out if they need to. |
#1214 implements this as a @bfirsh, to your point, we can absolutely iterate towards making automatic behavior better. We should eventually have it so that @technillogue has a PR to allow users to specify a custom base image in #1229. |
One weird trick to save 20GB of user bandwidth and cut our cold start times in half.
I'm not sure how to set up the config to default to false though.