Fix issue 678: Make it possible to store :db/id as a keyword value (#679

)
replikativ · Jun 8, 2024 · 17a22d8 · 17a22d8
1 parent 78fbfb2
commit 17a22d8
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/src/datahike/db/transaction.cljc b/src/datahike/db/transaction.cljc
@@ -378,9 +378,12 @@
                      (assoc v (dbu/reverse-ref a-ident) eid)
                      (if reverse?
                        [:db/add v straight-a eid]
-                       [:db/add eid straight-a (if (and attribute-refs? (ds/is-system-keyword? v)) ;; translation of system enums
-                                                 (dbi/-ref-for db v)
-                                                 v)])))]
+                       [:db/add eid straight-a
+                        (if (and attribute-refs?
+                                 (dbu/is-attr? db straight-a-ident :db/systemAttribRef)
+                                 (ds/is-system-keyword? v)) ;; translation of system enums
+                          (dbi/-ref-for db v)
+                          v)])))]
     (if ensure
       (let [{:keys [:db.entity/attrs :db.entity/preds]} (-> db :schema ensure)]
         (if (empty? attrs)

diff --git a/src/datahike/db/utils.cljc b/src/datahike/db/utils.cljc
@@ -234,6 +234,11 @@
     :db.cardinality/many [:db.cardinality/many]
     :db.type/ref [:db.type/ref :db/index]
     :db.type/tuple [:db.type/tuple]
+
+    :db.type/valueType [:db/systemAttribRef]
+    :db.type/cardinality [:db/systemAttribRef]
+    :db.type/unique [:db/systemAttribRef]
+
     (if (= k :db/ident)
       [:db/ident]
       (when (true? v)

diff --git a/test/datahike/test/attribute_refs/differences_test.cljc b/test/datahike/test/attribute_refs/differences_test.cljc
@@ -216,6 +216,24 @@
                #{:name}))
         (d/release conn)))))
 
+(deftest test-store-db-id-as-keyword
+  (doseq [cfg (init-cfgs)]
+    (testing "Do not resolve enums in keyword DB"
+      (let [conn (setup-db cfg)]
+        (d/transact conn [{:db/ident :attribute-to-use
+                           :db/cardinality :db.cardinality/one
+                           :db/valueType :db.type/keyword}])
+        (d/transact conn [{:attribute-to-use :the-location}
+                          {:attribute-to-use :db/id}])
+        (is (= #{[:the-location]
+                 [:db/id]}
+               (d/q '[:find ?v
+                      :in $ ?a
+                      :where
+                      [_ :attribute-to-use ?v]]
+                    @conn)))
+        (d/release conn)))))
+
 (deftest test-indexing
   (let [[no-ref-cfg ref-cfg] (init-cfgs)
         schema [{:db/ident :name