Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version ex command #181

Merged
merged 1 commit into from
Nov 4, 2024
Merged

add version ex command #181

merged 1 commit into from
Nov 4, 2024

Conversation

nightwing
Copy link
Collaborator

Copy link
Member

@masad-frost masad-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make more sense to import { version } from '../package.json'? We've done that in another cm package and it works fine with the build pipeline, not sure if it breaks for cm5.

@nightwing
Copy link
Collaborator Author

I did not manage to get cm build to inline version imported from package.json, and i did not want to leave require('../package.json'); in dist code. Also it would require more work to be compatible with web-demo.html .

@nightwing nightwing merged commit fb9dd58 into master Nov 4, 2024
1 check passed
@nightwing nightwing deleted the version branch November 4, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants