Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully automatic release versioning #197

Merged
merged 5 commits into from
Dec 9, 2023
Merged

Fully automatic release versioning #197

merged 5 commits into from
Dec 9, 2023

Conversation

blast-hardcheese
Copy link
Collaborator

Why

Removing footguns and making releases less cumbersome overall.

What changed

  • Moving ownership of version-number-setting into GHA
  • Bumping copyright

Test plan

  • Cutting the same version as was just released should kick the tires without breaking anything.

Rollout

  • This is fully backward and forward compatible

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner December 9, 2023 01:04
@blast-hardcheese blast-hardcheese requested review from masad-frost and removed request for a team December 9, 2023 01:04
ryantm
ryantm approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blast-hardcheese blast-hardcheese merged commit e6bd7a9 into master Dec 9, 2023
5 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/fully-automatic-release-versioning branch December 9, 2023 01:24
@blast-hardcheese blast-hardcheese added the chore Incidental change that should not impact released library label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@masad-frost masad-frost Awaiting requested review from masad-frost masad-frost is a code owner automatically assigned from replit/devex

Assignees
No one assigned
Labels
chore Incidental change that should not impact released library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blast-hardcheese @ryantm