Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dependency tending #199

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

blast-hardcheese
Copy link
Collaborator

Why

As far as I can guess, our dependency pinning seems to have prevented dependabot from tending older libraries. Free these, as well as reshuffle dependency groups. Having Sphinx broken out to docs means that should we need to, we can explicitly install on an older Python runtime without having to worry about Sphinx needing Python>=3.9.

What changed

  • Reflect recommended urllib3 range
  • Switching from ^ to >= for dev dependencies

Test plan

  • Ran unittest against 3.8

Rollout

  • This is fully backward and forward compatible

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner December 11, 2023 22:11
@blast-hardcheese blast-hardcheese requested review from ryantm and removed request for a team December 11, 2023 22:11
@blast-hardcheese blast-hardcheese added the chore Incidental change that should not impact released library label Dec 11, 2023
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) December 11, 2023 22:16
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Which dependencies are we hoping Dependabot will tend to? urllib3 or the dev ones?

@blast-hardcheese blast-hardcheese merged commit cf59777 into master Dec 11, 2023
5 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/more-dependency-tending branch December 11, 2023 22:23
@blast-hardcheese
Copy link
Collaborator Author

@ryantm Moving towards "all of them" from "few of them"

@blast-hardcheese
Copy link
Collaborator Author

Ideally, if CI passes we should be able to merge the PR. With sufficiently sensible dep ranges it should help people write better/more secure services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Incidental change that should not impact released library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants