feat/proxy healthcheck through host proxy #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blast-hardcheese
force-pushed
the
dstewart/feat/proxy-healthcheck-through-host-proxy
branch
from
c2adcae
to
1aaf529
Compare
blast-hardcheese
force-pushed
the
dstewart/feat/proxy-healthcheck-through-host-proxy
branch
3 times, most recently
from
d86eb8e
to
70692e9
Compare
blast-hardcheese
changed the base branch from
main
to
dstewart/chore/avoid-bespoke-protocol
masad-frost
reviewed
Nov 15, 2024
| @@ -330,7 +355,7 @@ export async function setupContainer( | |||
|
|
|||
| // warm up the container. wait 10s until we get at least one good result back. | |||
| if (type === 'server') { | |||
| healthCheck(container, network); | |||
| await healthCheck(container, network, hostPortMapping); | |||
masad-frost
approved these changes
Nov 15, 2024
|
looks good at face value, but "why" is not clear to me. |
macOS docker doesn't (can't?) expose the docker subnets to the host due to virtualization boundary. The reason tests passed locally at all (on mac) was because of the missing |
blast-hardcheese
force-pushed
the
dstewart/chore/avoid-bespoke-protocol
branch
from
4e57c85
to
7738f54
Compare
blast-hardcheese
force-pushed
the
dstewart/feat/proxy-healthcheck-through-host-proxy
branch
from
70692e9
to
5b077b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8080awaithealthcheck calls