Skip to content

Commit

Permalink
EPMRPP-96394 || Code Review fix - 1
Browse files Browse the repository at this point in the history
  • Loading branch information
BlazarQSO committed Oct 22, 2024
1 parent 0ff7557 commit de7e8f6
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
8 changes: 6 additions & 2 deletions app/src/components/fields/searchField/searchField.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import { useEffect, useState } from 'react';
import PropTypes from 'prop-types';
import { useTracking } from 'react-tracking';
import { FieldText, SearchIcon } from '@reportportal/ui-kit';
import { BaseIconButton, FieldText, SearchIcon } from '@reportportal/ui-kit';
import classNames from 'classnames/bind';
import styles from './searchField.scss';

Expand Down Expand Up @@ -79,7 +79,11 @@ export const SearchField = ({
onBlur={handleBlur}
placeholder={placeholder}
loading={isSearchActive && isLoading}
startIcon={<SearchIcon />}
startIcon={
<BaseIconButton>
<SearchIcon />
</BaseIconButton>
}
className={cx('search-field')}
maxLength={256}
collapsible
Expand Down
2 changes: 1 addition & 1 deletion app/src/controllers/filter/withFilter.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const withFilter = ({ filterKey = FILTER_KEY, namespace } = {}) => (Wrapp

handleFilterChange = debounce((value) => {
this.props.updateFilter(value || undefined);
}, 300);
}, 1000);

render() {
const { filter, updateFilter, ...rest } = this.props;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import styles from './organizationsPageHeader.scss';

const cx = classNames.bind(styles);

const SearchFieldWitFilter = withFilter({ filterKey: SEARCH_KEY })(SearchField);
const SearchFieldWithFilter = withFilter({ filterKey: SEARCH_KEY })(SearchField);

export const OrganizationsPageHeader = ({ isEmpty, searchValue, setSearchValue }) => {
const { formatMessage } = useIntl();
Expand All @@ -44,7 +44,7 @@ export const OrganizationsPageHeader = ({ isEmpty, searchValue, setSearchValue }
<div className={cx('actions')}>
{!isEmpty && (
<div className={cx('icons')}>
<SearchFieldWitFilter
<SearchFieldWithFilter
isLoading={projectsLoading}
searchValue={searchValue}
setSearchValue={setSearchValue}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,6 @@
svg {
width: 16px;
height: 16px;

path {
fill: $COLOR--e-300;
}
}

i {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import userIcon from './img/user-inline.svg';

const cx = classNames.bind(styles);

const SearchFieldWitFilter = withFilter({ filterKey: SEARCH_KEY })(SearchField);
const SearchFieldWithFilter = withFilter({ filterKey: SEARCH_KEY })(SearchField);

export const ProjectsPageHeader = ({
hasPermission,
Expand Down Expand Up @@ -87,7 +87,7 @@ export const ProjectsPageHeader = ({
<div className={cx('actions')}>
{isNotEmpty && (
<div className={cx('icons')}>
<SearchFieldWitFilter
<SearchFieldWithFilter
isLoading={projectsLoading}
searchValue={searchValue}
setSearchValue={setSearchValue}
Expand Down

0 comments on commit de7e8f6

Please sign in to comment.