-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-90680 || Popover is broken in sidebar #3819
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/orgs #3819 +/- ##
=============================================
Coverage 60.06% 60.06%
=============================================
Files 79 79
Lines 859 859
Branches 123 123
=============================================
Hits 516 516
Misses 316 316
Partials 27 27 ☔ View full report in Codecov by Sentry. |
path { | ||
fill: $COLOR--white-two; | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks as a duplicate of lines 135-147.
Can in be handled via single set of such styles?
Another comment is about using relative tags selectors (button > div).
Can we avoid them here in favor of classes to less depend on child components HTML structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 Done.
2 These changes will be in the component from the component library, so it's better to leave it that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to handle point 2 in the scope of sidebar structure improvements.
Quality Gate passedIssues Measures |
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?manage:translations
script?Visuals