Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-90680 || Popover is broken in sidebar #3819

Merged
merged 3 commits into from
May 6, 2024

Conversation

BlazarQSO
Copy link
Contributor

@BlazarQSO BlazarQSO commented May 2, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.06%. Comparing base (3d6869c) to head (24ad0e4).

Additional details and impacted files
@@              Coverage Diff              @@
##           feature/orgs    #3819   +/-   ##
=============================================
  Coverage         60.06%   60.06%           
=============================================
  Files                79       79           
  Lines               859      859           
  Branches            123      123           
=============================================
  Hits                516      516           
  Misses              316      316           
  Partials             27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

path {
fill: $COLOR--white-two;
}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as a duplicate of lines 135-147.
Can in be handled via single set of such styles?

Another comment is about using relative tags selectors (button > div).
Can we avoid them here in favor of classes to less depend on child components HTML structure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Done.
2 These changes will be in the component from the component library, so it's better to leave it that way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to handle point 2 in the scope of sidebar structure improvements.

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BlazarQSO BlazarQSO merged commit c4eb11b into feature/orgs May 6, 2024
9 checks passed
@BlazarQSO BlazarQSO deleted the fix/EPMRPP-90680-popover-is-broken branch May 6, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants