Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-90473 || Report Launch as Important #3830

Merged
merged 1 commit into from
May 10, 2024

Conversation

Vadim73i
Copy link
Contributor

@Vadim73i Vadim73i commented May 9, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.50%. Comparing base (e1cb3fb) to head (eb969e4).

Files Patch % Lines
app/src/common/constants/retentionPolicy.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3830      +/-   ##
===========================================
- Coverage    60.57%   60.50%   -0.07%     
===========================================
  Files           79       80       +1     
  Lines          865      866       +1     
  Branches       127      127              
===========================================
  Hits           524      524              
- Misses         314      315       +1     
  Partials        27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -195,6 +197,12 @@ export class ItemInfo extends Component {
</div>

<div className={cx('additional-info')}>
{value.retentionPolicy === RETENTION_POLICY.IMPORTANT && (
<span className={cx('retention-policy')}>
<div className={cx('star-icon')}>{Parser(StarIcon)}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow the correct HTML structure and don't put block elements inside the inline elements.
I suppose the div here can be easily replaced by span.
W3C recommendation, community discussions

@AmsterGet AmsterGet merged commit f284ca2 into develop May 10, 2024
8 checks passed
@AmsterGet AmsterGet deleted the feature/EPMRPP-90473-Report-Launch-as-Important branch May 10, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants