Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send payload for ceremony, metadata update and sign #620

Merged
merged 13 commits into from
Jun 18, 2024

Conversation

MVrachev
Copy link
Member

@MVrachev MVrachev commented Jun 14, 2024

Note: Review and merge after merging #612

Description

Add send payload for ceremony, metadata update and sign.

Related to: #533

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Additional requirements

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Code of Conduct

By submitting this PR, you agree to follow our Code of Conduct.

  • I agree to follow this project's Code of Conduct

MVrachev added 6 commits June 13, 2024 19:36
This way we would be able to set settings.SERVER for all "admin"
sub commands.

Signed-off-by: Martin Vrachev <[email protected]>
Rename the ceremony "output" argument and sign "--save" option to become
consistent using the same option "--out".

Signed-off-by: Martin Vrachev <[email protected]>
Making the sign input file as an "--in" option makes more sense
considering we added an "--out" option in the previous commits.

Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
@MVrachev MVrachev self-assigned this Jun 14, 2024
@MVrachev
Copy link
Member Author

MVrachev commented Jun 14, 2024

I had problems running locally plantuml.
@kairoaraujo could you please run it locally and update especially https://github.com/repository-service-tuf/repository-service-tuf-cli/blob/main/docs/source/_static/repository-service-tuf-cli-C3.png diagram as I made changes there.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (47d0a69) to head (6edd6ec).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   98.90%   98.96%   +0.06%     
==========================================
  Files          20       30      +10     
  Lines        1367     1931     +564     
==========================================
+ Hits         1352     1911     +559     
- Misses         15       20       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MVrachev MVrachev force-pushed the send-payload branch 2 times, most recently from 85b0cde to 7730bec Compare June 14, 2024 13:42
MVrachev added 3 commits June 18, 2024 16:11
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
@kairoaraujo kairoaraujo merged commit f8b9752 into repository-service-tuf:main Jun 18, 2024
14 checks passed
@MVrachev MVrachev deleted the send-payload branch June 19, 2024 10:07
@MVrachev
Copy link
Member Author

The changes from pr #612 pr are part of this pr.
Commits from Make "--api-server" an admin option up to Fix unit tests were all part of #612 and are discussed there, but due to mistake we merged this pr first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants