-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add send payload for ceremony
, metadata update
and sign
#620
Add send payload for ceremony
, metadata update
and sign
#620
Conversation
This way we would be able to set settings.SERVER for all "admin" sub commands. Signed-off-by: Martin Vrachev <[email protected]>
Rename the ceremony "output" argument and sign "--save" option to become consistent using the same option "--out". Signed-off-by: Martin Vrachev <[email protected]>
Making the sign input file as an "--in" option makes more sense considering we added an "--out" option in the previous commits. Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
I had problems running locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 98.90% 98.96% +0.06%
==========================================
Files 20 30 +10
Lines 1367 1931 +564
==========================================
+ Hits 1352 1911 +559
- Misses 15 20 +5 ☔ View full report in Codecov by Sentry. |
85b0cde
to
7730bec
Compare
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
The changes from pr #612 pr are part of this pr. |
Note: Review and merge after merging #612
Description
Add send payload for
ceremony
,metadata update
andsign
.Related to: #533
Types of changes
Additional requirements
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct.