Add '--dry-run' option for 'ceremony' and 'sign' commands #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The '--dry-run' option scope is regarding the commands output. This means that when the option is used it will not influence the input options. Instead it will directly interfere with the output. If '--dry-run' is used, then the CLI will ignore both '--api-server' admin option and the RSTUF configuration file and it's corresponding SERVER option. Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Signed-off-by: Martin Vrachev <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
+ Coverage 98.90% 98.96% +0.06%
==========================================
Files 20 30 +10
Lines 1367 1936 +569
==========================================
+ Hits 1352 1916 +564
- Misses 15 20 +5 ☔ View full report in Codecov by Sentry. |
kairoaraujo
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The '--dry-run' option scope is regarding the command output.
This means that when the option is used it will not influence the
input options.
Instead, it will directly interfere with the output. If '--dry-run'
is used, then the CLI will ignore both '--api-server' admin option
and the RSTUF configuration file and its corresponding SERVER option.
Signed-off-by: Martin Vrachev [email protected]
Related to #533.
Types of changes
Additional requirements
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct.