Do not shadow helpers with same method but more params #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two helper methods are the same, but have different arguments (for example:
api_v1_cats_owners_path(id: 1)
vsapi_v1_cats_owners_path(id: 1, owner_id: 2)
) if the helper method with the least number of arguments is defined first (because the route was defined first) then it will shadow the longer route.Example:
Consider the following routes:
The helper methods return:
which is wrong.
api_v1_cats_owners_path(id: 1, owner_id: 2)
should return'/api/v1/cats/1/owners/2.json'
This PR fixes this issue in the simplest possible way: when
GrapeRouteHelpers::AllRoutes
is generating@decorated_routes
, it sorts the routes in descending order by the count ofdynamic_path_segments
it has.Fixes #22