-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission for #95 #142
base: master
Are you sure you want to change the base?
Submission for #95 #142
Conversation
Hi, please find below a review submitted by one of the reviewers: Score: 5 CODE COMMUNICATION WITH THE ORIGINAL AUTHORS HYPERPARAMETER SEARCH They do though introduce a study of the impact of adding biases in the normalization as well. ABLATION STUDIES DISCUSSION ON RESULTS However, I do not understand why Batch Norm is not included in Figure 3. RECOMMENDATIONS FOR REPRODUCIBILITY OVERALL ORGANIZATION AND CLARITY My main criticism is on Figure 1, which is actually taken from the ICLR submission. Firstly, citation should be added and, secondly, it is almost impossible to compare the relevant curves of Figure 1 with the ones obtained in Figure 2. Only those plots being reproduced should be included in a single Figure comparing the reproducibility and the original values. This central result is totally missing in the report, so I encourage the authors to create a graph with a fair comparison of the obtained results and the ones reported in the ICLR submission. Confidence : 4 |
Hi, please find below a review submitted by one of the reviewers: Score: 5 Equi-Normalization is well-justified in the Introduction of the reproduced paper. Code The code is open-source. All the code is in one Jupyter notebook. Cannot comment much about the codebase itself, but the structure and the comments looks good. Communication with the Original Author The authors mention that they have communicated with the authors via OpenReview. The communication can be found in OpenReview. Hyperparameter Search No hyperparameter search was performed. Ablation Study Ablation study of adding bias to the neural network was performed. No other ablation study is given, other than the ones already in the original paper (BN, ENorm, BN+ENorm). Discussion on Results The authors give an adequate comparison between published and reproduced results. There could be more speculations about the the p=19 case. Recommendations for Reproducibility There was no suggestions to the author about possible improvements in terms of reproducibility. Overall Organization and Clarity Overall, the paper was written coherently. Here are points that I was particularly impressed with:
Here are some parts of the paper I wished for more information:
Here are some minor fixes I recommend:
Thank you! Score (1 |
Hi, please find below a review submitted by one of the reviewers: Score: 4 |
Reviewer 2 comment : In detail, it would have been nice to take advantage of notebook format as to show the reproduced results. In present state, it is a bit hard to judge as to what the output would look like. |
Submission for #95