Fixes user update #12

rer7891 · 2020-01-22T02:42:07Z

What functionality does this accomplish?

closes #

Description:

What did you struggle on to complete?

Current Test Suite:

Test Coverage Percentage: x%

No Tests have been changed
Some Tests have been changed
All of the Tests have been changed(Please describe what in the world happened):
New Tests added for new features

Checklist:

My code has no unused/commented out code
I have reviewed my code
I have commented my code, particularly in hard-to-understand areas
I have fully tested my code
I have partially tested my code (please explain why):

Helpful Resources:

Resource link AND small description of info gathered/learned

Review Requests(optional):

Please include a gif of how you feel about this branch:

hound · 2020-01-22T02:42:12Z

spec/features/admin/user/updates_role_status.rb

    user.reload
-    expect(user.role).to eq("merchant_admin")
+    expect(user.role).to eq("user")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-22T02:42:12Z

spec/features/admin/user/updates_role_status.rb

+    within "#user-#{user.id}" do
+      select "user", :from => "Role"
+      select("Vintage Vampire", from: "Merchant").select_option
+      click_on "Update"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-22T02:42:12Z

spec/features/admin/user/updates_role_status.rb


+    within "#user-#{user.id}" do
+      select "user", :from => "Role"
+      select("Vintage Vampire", from: "Merchant").select_option


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-22T02:42:12Z

spec/features/admin/user/updates_role_status.rb


+    within "#user-#{user.id}" do
+      select "user", :from => "Role"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.

hound · 2020-01-22T02:42:12Z

spec/features/admin/user/updates_role_status.rb

+
+    visit admin_dash_users_path
+
+    expect(user.role).to eq("merchant_employee")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-22T02:42:13Z

spec/features/admin/user/updates_role_status.rb

+    end
+
+    user.reload
+    expect(user.role).to eq("merchant_employee")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-22T02:42:13Z

spec/features/admin/user/updates_role_status.rb

@@ -15,12 +15,36 @@

    within "#user-#{user.id}" do
      expect(page).to have_content('Role')
-      select "merchant_admin", :from => "Role"
+      select "merchant_employee", :from => "Role"
+      select("Vintage Vampire", from: "Merchant").select_option


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-22T02:42:13Z

spec/features/admin/user/updates_role_status.rb

@@ -15,12 +15,36 @@

    within "#user-#{user.id}" do
      expect(page).to have_content('Role')
-      select "merchant_admin", :from => "Role"
+      select "merchant_employee", :from => "Role"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.

hound · 2020-01-22T02:42:14Z

app/controllers/admin/users_controller.rb

+      if params[:user][:role] == "merchant_employee"
+        @user.merchant_id = @merchant.id
+        @user.save
+      elsif params[:user][:role] != "merchant_employee" && @user.merchant_id != nil


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/NonNilCheck: Prefer !expression.nil? over expression != nil.
Metrics/LineLength: Line is too long. [83/80]

hound · 2020-01-22T02:42:14Z

app/controllers/admin/users_controller.rb

@@ -1,6 +1,7 @@
 class Admin::UsersController < Admin::BaseController
  def index
    @users = User.unscoped.all
+


Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.

hound · 2020-01-25T15:56:42Z

spec/features/admin/user/updates_role_status.rb

+    expect(user.role).to eq("user")
+    expect(user.merchant_id).to eq(nil)
+save_and_open_page
+    expect(page).to have_content("Please try again. You may need to choose a merchant.")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [88/80]

hound · 2020-01-25T15:56:43Z

spec/features/admin/user/updates_role_status.rb

+    user.reload
+    expect(user.role).to eq("user")
+    expect(user.merchant_id).to eq(nil)
+save_and_open_page


Layout/IndentationConsistency: Inconsistent indentation detected.
Lint/Debugger: Remove debugger entry point save_and_open_page.

hound · 2020-01-25T15:56:43Z

spec/features/admin/user/updates_role_status.rb

+    end
+
+    user.reload
+    expect(user.role).to eq("user")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-25T15:56:43Z

spec/features/admin/user/updates_role_status.rb

+
+    within "#user-#{user.id}" do
+      select "merchant_employee", :from => "Role"
+      click_on "Update"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-25T15:56:43Z

spec/features/admin/user/updates_role_status.rb

+    expect(user.role).to eq("user")
+
+    within "#user-#{user.id}" do
+      select "merchant_employee", :from => "Role"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.

hound · 2020-01-25T15:56:43Z

spec/features/admin/user/updates_role_status.rb

+  it "won't update if no merchant is given for a merchant employee" do
+    admin = create(:admin_user)
+    user = create(:random_user)
+    merchant = create(:ray_merchant)


Lint/UselessAssignment: Useless assignment to variable - merchant.

hound · 2020-01-25T15:56:44Z

app/controllers/admin/users_controller.rb

+      redirect_to admin_dash_users_path
+    else
+      flash[:error] = "Please try again. You may need to choose a merchant."
+      redirect_to admin_dash_users_path


Style/IdenticalConditionalBranches: Move redirect_to admin_dash_users_path out of the conditional.

hound · 2020-01-25T15:56:44Z

app/controllers/admin/users_controller.rb

+      flash[:success] = "The user role has been updated to #{@user.role}."
+      redirect_to admin_dash_users_path
+    else
+      flash[:error] = "Please try again. You may need to choose a merchant."


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2020-01-25T15:56:44Z

app/controllers/admin/users_controller.rb

+      end
+    if @user.update
+      flash[:success] = "The user role has been updated to #{@user.role}."
+      redirect_to admin_dash_users_path


Style/IdenticalConditionalBranches: Move redirect_to admin_dash_users_path out of the conditional.

hound · 2020-01-25T15:56:44Z

app/controllers/admin/users_controller.rb

-    flash[:success] = "The user role has been updated to #{@user.role}."
-    redirect_to admin_dash_users_path
+    @merchant = Merchant.where(name: params[:user][:merchant]).first
+      if params[:user][:role] == "merchant_employee" && @merchant


Layout/IndentationConsistency: Inconsistent indentation detected.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Fixes user update

8917734

hound bot reviewed Jan 22, 2020

View reviewed changes

Adds testing to user role update

0277558

hound bot reviewed Jan 25, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes user update #12

Fixes user update #12

rer7891 commented Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 22, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020

hound bot Jan 25, 2020


		visit admin_dash_users_path

		expect(user.role).to eq("merchant_employee")

Fixes user update #12

Are you sure you want to change the base?

Fixes user update #12

Conversation

rer7891 commented Jan 22, 2020

What functionality does this accomplish?

What did you struggle on to complete?

Current Test Suite:

Test Coverage Percentage: x%

Checklist:

Helpful Resources:

Review Requests(optional):

Please include a gif of how you feel about this branch:

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 22, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment

hound bot Jan 25, 2020

Choose a reason for hiding this comment