Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Core into compiler repo #7108

Merged
merged 13 commits into from
Oct 20, 2024
Merged

Move Core into compiler repo #7108

merged 13 commits into from
Oct 20, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 19, 2024

Core e230098

  • All files flat under runtime (as subdirs don't work there yet)
  • Prefix Core__ removed, double underscores replaced by single underscores
  • Moved Core global stuff into Pervasives
  • OCaml compat modules moved to tests.
  • @rescript/core removed from playground bundle
  • Add and open Pervasives_mini while building runtime. Otherwise we cannot refer to other modules from Pervasives.res because of cyclic dependencies.

@cknitt cknitt force-pushed the core branch 3 times, most recently from 8f39951 to 489a3be Compare October 20, 2024 06:01
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax Benchmarks

Benchmark suite Current: 01daa07 Previous: e1b7fb7 Ratio
Parse RedBlackTree.res - time/run 1.2031524866666665 ms 1.2123143266666667 ms 0.99
Parse RedBlackTree.res - allocs/run 199057 words 199057 words 1
Print RedBlackTree.res - time/run 2.3608493999999998 ms 2.3104395133333333 ms 1.02
Print RedBlackTree.res - allocs/run 236403 words 236403 words 1
Print RedBlackTreeNoComments.res - time/run 2.14703054 ms 2.10057036 ms 1.02
Print RedBlackTreeNoComments.res - allocs/run 249186 words 249186 words 1
Parse Napkinscript.res - time/run 38.63837942 ms 39.28006235333333 ms 0.98
Parse Napkinscript.res - allocs/run 8670066 words 8670066 words 1
Print Napkinscript.res - time/run 71.53132409999999 ms 77.00100409999999 ms 0.93
Print Napkinscript.res - allocs/run 9776327 words 9776327 words 1
Parse HeroGraphic.res - time/run 5.049344153333333 ms 5.13472718 ms 0.98
Parse HeroGraphic.res - allocs/run 1219326 words 1219326 words 1
Print HeroGraphic.res - time/run 8.923265433333333 ms 8.775952553333333 ms 1.02
Print HeroGraphic.res - allocs/run 1396466 words 1396466 words 1

This comment was automatically generated by workflow using github-action-benchmark.

@cknitt cknitt force-pushed the core branch 4 times, most recently from 29f1328 to bc1fee9 Compare October 20, 2024 11:24
@cknitt cknitt marked this pull request as ready for review October 20, 2024 12:27
@cknitt cknitt requested review from zth and cristianoc October 20, 2024 12:29
@cknitt cknitt changed the title WIP: Move Core into compiler repo Move Core into compiler repo Oct 20, 2024
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think there are a few places related to unboxed variants that need updating. But we can do that in a separate PR if that's the case.

@cknitt cknitt merged commit a3dee73 into master Oct 20, 2024
20 checks passed
@cknitt cknitt deleted the core branch October 20, 2024 18:37
@smorimoto
Copy link
Contributor

Will things like Option still stay under the Belt?

@zth
Copy link
Collaborator

zth commented Oct 23, 2024

@smorimoto Belt will still have its option module, but since Core became a thing we recommend using the one from Core (and with this merge the global Option module). Belt will stick around, likely as an external package, for more advanced data structures + backwards compat.

@smorimoto
Copy link
Contributor

Got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants