-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array.findLast and other missing functions #126
base: main
Are you sure you want to change the base?
Conversation
I have no idea why the tests aren't working. It works for me. |
It fails because the function does not exist in Node.js 16. Node.js 16 is included in the CI matrix because it's a Long Term Support release. It will stop being supported in September, at which point the matrix should be updated and the checks should pass. |
Now that Node.js 16 has reached end-of-life, will this be merged for the next release? And thanks, Justin; I needed findLastIndex! |
Some missing functions from the Array module. In particular the
findLast
variants.indexOfFromOpt
: add code and docslastIndexOf
: docs, testslastIndexOfOpt
: testslastIndexOfFrom
: docs, testsfindLast
: code, docs, testsfindLastIndex
: code, docs, testsfindLastIndexOpt
: code, docs, testsfindLastIndexWithIndex
: code, docs, testsfindLastIndexWithIndexOpt
: code, docs