Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.findLast and other missing functions #126

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jmagaram
Copy link
Contributor

Some missing functions from the Array module. In particular the findLast variants.

indexOfFromOpt: add code and docs
lastIndexOf : docs, tests
lastIndexOfOpt : tests
lastIndexOfFrom : docs, tests
findLast : code, docs, tests
findLastIndex : code, docs, tests
findLastIndexOpt : code, docs, tests
findLastIndexWithIndex : code, docs, tests
findLastIndexWithIndexOpt : code, docs

@jmagaram
Copy link
Contributor Author

I have no idea why the tests aren't working. It works for me.

@glennsl
Copy link
Contributor

glennsl commented Mar 29, 2023

It fails because the function does not exist in Node.js 16. Node.js 16 is included in the CI matrix because it's a Long Term Support release. It will stop being supported in September, at which point the matrix should be updated and the checks should pass.

@cvoight
Copy link

cvoight commented Sep 28, 2023

Now that Node.js 16 has reached end-of-life, will this be merged for the next release? And thanks, Justin; I needed findLastIndex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants