Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: retrieve Node.js version from .nvmrc #7214

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

smorimoto
Copy link
Contributor

No description provided.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@smorimoto smorimoto force-pushed the package-json-node-version branch from e957d01 to f266a63 Compare December 24, 2024 01:52
@smorimoto smorimoto changed the title ci: retrieve Node.js version from package.json ci: retrieve Node.js version from .nvmrc Dec 25, 2024
@cknitt
Copy link
Member

cknitt commented Dec 27, 2024

Ah, this has conflicts now - could you rebase @smorimoto?

@smorimoto smorimoto force-pushed the package-json-node-version branch from f266a63 to 5497b7f Compare December 27, 2024 12:42
@smorimoto
Copy link
Contributor Author

@cknitt Done!

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@cknitt cknitt merged commit 8ee10cc into rescript-lang:master Dec 27, 2024
20 checks passed
@smorimoto smorimoto deleted the package-json-node-version branch December 27, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants