Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST: Remove Pstr_class #7242

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 11, 2025

I think this one is also unused, @cristianoc and @cknitt please let me know if there are others you see.

  • Pstr_class
  • Psig_class
  • Pstr_class_type
  • Psig_class_type
  • Tstr_class
  • Tstr_class_type
  • Tsig_class
  • Tsig_class_type

@nojaf nojaf marked this pull request as ready for review January 11, 2025 14:05
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if anything is missing from #7243, and it can be integrated here.

@nojaf
Copy link
Contributor Author

nojaf commented Jan 13, 2025

Missing items from #7243 were added here.
Ready for review @cknitt!

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cristianoc cristianoc merged commit 1338ea2 into rescript-lang:master Jan 13, 2025
20 checks passed
@nojaf nojaf deleted the remove-Pstr_class branch January 13, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants