Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 - Move logging to env_logger #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🔊 - Move logging to env_logger #126

wants to merge 1 commit into from

Conversation

rolandpeelen
Copy link
Member

@rolandpeelen rolandpeelen commented Jun 26, 2024

Change println statements to log::[warn, log, error, ...]. Adds the ability to use log levels for CI. For instance, running RUST_LOG=warn rewatch build will only use warn and up.

See the env_logger crate for more info.

This adds the ability to use log levels for CI. Running `RUST_LOG=warn
rewatch build` will only use `warn` and up.

See the [env_logger](https://docs.rs/env_logger/latest/env_logger/)
crate for more info.
@rolandpeelen
Copy link
Member Author

Should give you a fix for #113 -- @cknitt 🙌

@rolandpeelen rolandpeelen requested a review from cknitt June 26, 2024 18:03
@cknitt
Copy link
Member

cknitt commented Jun 26, 2024

Great! Thanks a lot!

Tests are failing though.

From the user experience point of view I think it would be nicer to have a command line option for the log level (or maybe even just a --quiet option) instead of having to set an environment variable called RUST_LOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants