Add pnpm support #91
Merged
Add pnpm support #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DZakh
commented
Mar 16, 2024
| project_root, | ||
| workspace_root.to_owned(), | ||
| ); | ||
|
|
||
| Dependency { | ||
| name: package_name.to_owned(), | ||
| bsconfig, | ||
| path, | ||
| path: canonical_path, |
There was a problem hiding this comment.
Ideally to start storing both canonical and human readable paths in the future, to use it for more human readable compilation errors.
There was a problem hiding this comment.
hmm yeah! But in some cases the canonical is the more user readable one (monorepo paths that are symlinked in node_modules)
|
The clean build is only 3 seconds faster, but I have my hopes on incremental builds in watch mode. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It compiles 🤩
Solves #74