Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated grammar #36

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Updated grammar #36

merged 1 commit into from
Aug 31, 2023

Conversation

himbosurf
Copy link
Contributor

changed the grammar on line 50.

changed the grammar on line 50.
@himbosurf himbosurf requested a review from kachenb August 31, 2023 10:27
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/researchsoftwaretrainingNL/OSF-Rpackaging-lesson/compare/md-outputs..md-outputs-PR-36

The following changes were observed in the rendered markdown documents:

 getting_started.md | 2 +-
 introduction.md    | 2 +-
 md5sum.txt         | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-08-31 10:29:27 +0000

@kachenb
Copy link
Collaborator

kachenb commented Aug 31, 2023

Thanks! I'll approve it.

Copy link
Collaborator

@kachenb kachenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@kachenb kachenb merged commit 4ed37ff into main Aug 31, 2023
3 checks passed
@himbosurf himbosurf deleted the grammar-patch-1 branch August 31, 2023 10:30
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
Auto-generated via {sandpaper}
Source  : 4ed37ff
Branch  : main
Author  : kachenb <[email protected]>
Time    : 2023-08-31 10:30:27 +0000
Message : Merge pull request #36 from researchsoftwaretrainingNL/grammar-patch-1

Updated grammar
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
Auto-generated via {sandpaper}
Source  : 382b47d
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-31 10:32:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 4ed37ff
Branch  : main
Author  : kachenb <[email protected]>
Time    : 2023-08-31 10:30:27 +0000
Message : Merge pull request #36 from researchsoftwaretrainingNL/grammar-patch-1

Updated grammar
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
Auto-generated via {sandpaper}
Source  : 382b47d
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-31 10:32:04 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 4ed37ff
Branch  : main
Author  : kachenb <[email protected]>
Time    : 2023-08-31 10:30:27 +0000
Message : Merge pull request #36 from researchsoftwaretrainingNL/grammar-patch-1

Updated grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants