Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #18 #40

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fixes #18 #40

merged 1 commit into from
Aug 31, 2023

Conversation

nrvanulzen
Copy link
Collaborator

@nrvanulzen I made this change, can you approve this

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/researchsoftwaretrainingNL/OSF-Rpackaging-lesson/compare/md-outputs..md-outputs-PR-40

The following changes were observed in the rendered markdown documents:

 licenses.md | 2 +-
 md5sum.txt  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-08-31 10:30:29 +0000

github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@nrvanulzen nrvanulzen requested a review from mkuzak August 31, 2023 10:32
@mkuzak
Copy link
Collaborator

mkuzak commented Aug 31, 2023

thanx @nrvanulzen

@mkuzak mkuzak merged commit 4e97191 into main Aug 31, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
Auto-generated via {sandpaper}
Source  : 4e97191
Branch  : main
Author  : Mateusz Kuzak <[email protected]>
Time    : 2023-08-31 10:35:32 +0000
Message : Merge pull request #40 from researchsoftwaretrainingNL/change-word-in-licenses-episode

fixes #18
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
Auto-generated via {sandpaper}
Source  : 734f97e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-31 10:37:21 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 4e97191
Branch  : main
Author  : Mateusz Kuzak <[email protected]>
Time    : 2023-08-31 10:35:32 +0000
Message : Merge pull request #40 from researchsoftwaretrainingNL/change-word-in-licenses-episode

fixes #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants