Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to R instead of Python in the introduction. #5

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Conversation

mkuzak
Copy link
Collaborator

@mkuzak mkuzak commented Aug 4, 2023

Resolves #3

@mkuzak mkuzak requested a review from liekelotte August 4, 2023 09:11
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/researchsoftwaretrainingNL/OSF-Rpackaging-lesson/compare/md-outputs..md-outputs-PR-5

The following changes were observed in the rendered markdown documents:

 introduction.md | 4 ++--
 md5sum.txt      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-08-04 09:23:10 +0000

Copy link
Collaborator

@liekelotte liekelotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing Python to R, could you make sure the grammar is correct after this review?

episodes/introduction.Rmd Outdated Show resolved Hide resolved
episodes/introduction.Rmd Outdated Show resolved Hide resolved
@mkuzak
Copy link
Collaborator Author

mkuzak commented Aug 4, 2023

Well spotted. Thanks. I'll merge your changes.

@mkuzak mkuzak requested a review from liekelotte August 4, 2023 09:22
Copy link
Collaborator

@liekelotte liekelotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your great work!

@liekelotte liekelotte merged commit b3c5e5e into main Aug 4, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 4, 2023
Auto-generated via {sandpaper}
Source  : b3c5e5e
Branch  : main
Author  : Lieke <[email protected]>
Time    : 2023-08-04 09:24:03 +0000
Message : Merge pull request #5 from researchsoftwaretrainingNL/solve-issue3

Refer to R instead of Python in the introduction.
github-actions bot pushed a commit that referenced this pull request Aug 4, 2023
Auto-generated via {sandpaper}
Source  : b89f323
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-04 09:25:48 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : b3c5e5e
Branch  : main
Author  : Lieke <[email protected]>
Time    : 2023-08-04 09:24:03 +0000
Message : Merge pull request #5 from researchsoftwaretrainingNL/solve-issue3

Refer to R instead of Python in the introduction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The introduction mentions Python instead of R
2 participants