-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-email): Respect user NODE_ENV #1756
Conversation
🦋 Changeset detectedLatest commit: 3719786 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@AshotN is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
I don't think we can give preference to the it also seems to cause a type error |
0426d02
to
868acde
Compare
I was trying to deploy the preview site. I am using https://github.com/node-config/node-config to handle my ENV files. Some of my email templates rely on variables from those env files. With react-email changing the NODE_ENV, I end up being unable to load the files. |
@AshotN Got it, I tested it out a bit and your way works just fine in the situation that I was mentioning. Have you tested this PR out to see if it fixes it in your case? What you can do to test it out is run |
To be honest, I have not tested it. It seemed like a simple change, but I will spend some time this week making sure. |
9bc8a14
to
f953e3c
Compare
74d49e5
to
6facd7c
Compare
83de70b
to
a03ac13
Compare
@gabrielmfern Sorry for the lag on my response, I just tested it on my local and it does solve my problem. I caught the branch back up. If there is anything else you need from me, let me know. Thanks! |
4ee4d1d
to
0187b0a
Compare
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
7eb68af#diff-c5c5ee3ee563e33630e1ad83f07d66cb99b9be9a662fa8f4f9d7a6d43e98b7d0
This commit caused
NODE_ENV
to no longer be respected and always becomedevelopment
This change will respect
NODE_ENV
and default todevelopment
if nothing is passed in.