Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle Factory #1222

Open
wants to merge 8 commits into
base: 4.0.0
Choose a base branch
from
Open

Oracle Factory #1222

wants to merge 8 commits into from

Conversation

akshatmittal
Copy link
Member

@akshatmittal akshatmittal commented Oct 29, 2024 •
edited
Loading

  • Exchange Rate Oracle
  • Curve LP Oracle
  • Yearn Curve LP Oracle

@tbrent tbrent mentioned this pull request Nov 6, 2024
Closed
tbrent
tbrent reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@tbrent tbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change one of the tests to use the RToken oracle? seems worth testing the entire space

contracts/facade/oracles/curve-oracle/CurveOracle.sol Outdated
revert BadOracleValue();
}

if (block.timestamp - updateTime > oracleConfig.timeout) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding a small buffer here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking of including it in the provided config itself, do you think it's worth including it here instead?

contracts/facade/oracles/exchange-rate/ExchangeRateOracle.sol Outdated Show resolved Hide resolved
test/oracles/CurveOracle.test.ts Outdated Show resolved Hide resolved
test/oracles/CurveOracle.test.ts Outdated Show resolved Hide resolved
test/oracles/CurveOracle.test.ts Show resolved Hide resolved
test/oracles/CurveOracle.test.ts Show resolved Hide resolved
test/oracles/CurveOracle.test.ts Show resolved Hide resolved
test/oracles/CurveOracle.test.ts Outdated Show resolved Hide resolved
@akshatmittal akshatmittal marked this pull request as ready for review November 7, 2024 11:33
@akshatmittal akshatmittal requested a review from tbrent November 7, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrent tbrent Awaiting requested review from tbrent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshatmittal @tbrent @pmckelvy1