Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved Data Flow in Purchase Reconciliation Tool #2953

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Jan 10, 2025

No description provided.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.51%. Comparing base (a197267) to head (357cd6c).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...econciliation_tool/purchase_reconciliation_tool.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2953      +/-   ##
===========================================
- Coverage    59.92%   58.51%   -1.41%     
===========================================
  Files          122      122              
  Lines        12131    12137       +6     
===========================================
- Hits          7269     7102     -167     
- Misses        4862     5035     +173     
Files with missing lines Coverage Δ
...a/doctype/purchase_reconciliation_tool/__init__.py 50.20% <ø> (-32.72%) ⬇️
...econciliation_tool/purchase_reconciliation_tool.py 22.94% <66.66%> (-1.64%) ⬇️

... and 7 files with indirect coverage changes

Impacted file tree graph

@Ninad1306
Copy link
Contributor Author

closes #2435

@Ninad1306 Ninad1306 requested a review from vorasmit January 10, 2025 13:30
@vorasmit vorasmit added the p1 label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants