-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for resque 2 #53
base: master
Are you sure you want to change the base?
Conversation
Update to support resque 2
Based on latest commit, your merge request will never be accepted @MWGNZ :/ |
Is this because it forces an upgrade to resque 2? What can we do to this PR to make it acceptable? |
I believe in that because this project has not been actively maintained (latest commit is from 2014) not because the changes itself. |
Remove deprecated rdoc spec statement
@brunoocasali @MWGNZ if we can get the travis CI moved to github actions, and rebase this on master, I can merge! |
any updates on this? i would really love this PR to be merged in master. |
@softbrada First step here is migrating to github actions so CI can run. resque, resque-scheduler, etc are all migrated over so it should be a copy/paste/edit. If someone else wants to throw up a PR for that, we can get this merged in! |
@iloveitaly any updates on getting this merged in |
Resque 2 has moved the Resque.redis.client namespace to Resque.redis._client and also started putting a deprecation warning in logs every time that Resque.redis.client gets called.
This fixes the namespace deprecation warning and allows resque-loner to work with resque 2