Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resque 2 #53

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

MWGNZ
Copy link

@MWGNZ MWGNZ commented Jul 8, 2019

Resque 2 has moved the Resque.redis.client namespace to Resque.redis._client and also started putting a deprecation warning in logs every time that Resque.redis.client gets called.

This fixes the namespace deprecation warning and allows resque-loner to work with resque 2

@brunoocasali
Copy link

Based on latest commit, your merge request will never be accepted @MWGNZ :/
I'll refer to your repository directly.

@david-mccullars
Copy link

Based on latest commit, your merge request will never be accepted @MWGNZ :/
I'll refer to your repository directly.

Is this because it forces an upgrade to resque 2? What can we do to this PR to make it acceptable?

@brunoocasali
Copy link

Based on latest commit, your merge request will never be accepted @MWGNZ :/
I'll refer to your repository directly.

Is this because it forces an upgrade to resque 2? What can we do to this PR to make it acceptable?

I believe in that because this project has not been actively maintained (latest commit is from 2014) not because the changes itself.

@iloveitaly
Copy link

@brunoocasali @MWGNZ if we can get the travis CI moved to github actions, and rebase this on master, I can merge!

@nvolker nvolker mentioned this pull request Sep 26, 2022
@softbrada
Copy link

any updates on this? i would really love this PR to be merged in master.

@iloveitaly
Copy link

@softbrada First step here is migrating to github actions so CI can run. resque, resque-scheduler, etc are all migrated over so it should be a copy/paste/edit. If someone else wants to throw up a PR for that, we can get this merged in!

@makrsmark makrsmark mentioned this pull request Jan 13, 2023
@arianf
Copy link

arianf commented Sep 21, 2023

@iloveitaly any updates on getting this merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants