-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of TRestDataSet #345
Conversation
… run time of selected files
I think it's important that unit tests are added for this class, now that we have the possibility to do it from the ground up. |
…orts, variable names...)
I agree, just waiting to see what happens with the files I prepared for testing the class. See https://root-forum.cern.ch/t/checkbytecount-and-streamer-error/52716/7 |
…k into jgalan_dataset
…tQunatity structure
examples/dataset.rml
Outdated
<parameter name="filePattern" value="../../framework-data/pipeline/dataset/BabyIAXO_TrueWolterMicromegasTest*.root"/> | ||
<filter metadata="TRestRun::fRunNumber" greaterThan="370" lowerThan="375"/> | ||
<filter metadata="TRestRun::fRunTag" contains="Test"/> | ||
<observables list="window_transmission:optics_efficiency:axionPhoton_probability:axionPhoton_transmission:boreExitGate_transmission"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why use :
as the separator? If it's correlated with a vector we can use rml auto parsing, like: {window_transmission,optics_efficiency,axionPhoton_probability,axionPhoton_transmission,boreExitGate_transmission}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, ,
separator is probably much better. I thought about it, perhaps we could use a Split
automatic separator identifier?
Such as we find on string, if we find only ,
, we use it.
We could use a wildcard Split separator to try to find the separator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated it at b388349
This PR is related to issue #13.
A class allowing to create datasets from an official REST data repository.
The class documentation has been pre-rendered at the following location: https://sultan.unizar.es/test/classTRestDataSet.html have a look!
RML setup would look as follows:
The class will be capable to generate a final txt file with the selected data, and a header with the origin of the data: