Jporron update veto peaks finder #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option to calculate the baseline excluding outliers is added.
It will calculate the median and standard deviation of a signal in the selected range considering only the 25-75% values, excluding big and small outliers. This might be important when calculating the VETO peaks, for example, as it uses the BaseLine (+ input threshold) to exclude small peaks.
If there are peaks (or negative regions) in the interval to calculate the sigma they will lead to a biased BaseLine. If there are many peaks, for example, the calculated BaseLine will be biased to bigger values and might eliminate clear peaks.
By calculating the BaseLine without the outliers (the peaks will be in the >75% region) the calculated value will be more precise.