options: reduce max delay to INT_MAX/1000

avoids potential multiplication overflow when the seconds are converted into milliseconds.
resurrecting-open-source-projects · May 31, 2023 · 3c89049 · 3c89049
1 parent d0ff51f
commit 3c89049
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/options.c b/src/options.c
@@ -391,7 +391,8 @@ void optionsParse(int argc, char *argv[])
             opt.delaySelection = *optarg == 'b';
             if (opt.delaySelection)
                 ++optarg;
-            opt.delay = optionsParseNum(optarg, 0, INT_MAX, &errmsg);
+            /* NOTE: div 1000 so that converting to milliseconds doesn't overflow */
+            opt.delay = optionsParseNum(optarg, 0, INT_MAX/1000, &errmsg);
             if (errmsg) {
                 errx(EXIT_FAILURE, "option --delay: '%s' is %s", optarg,
                     errmsg);