Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectionEdgeDestroy: misc cleanups #304

Merged
merged 3 commits into from
May 26, 2023

Commits on May 25, 2023

  1. selectionEdgeDestroy: bugfix + misc cleanups

    * xeventUnmap() did not check the union type before reading from it.
    * unmap event should always come, no need to sleep/retry 30 times.
    * remove xeventUnmap() and waitUnmapWindowNotify() entirely. the main
      logic is short enough to inline directly at the call site.
    * rather than unmapping the window, and then destroying it, destroy it
      directly and wait for the DestroyNotify event.
    * compare window ID against `None` rather than `0`. no functional
      difference, but using `None` is more idiomatic for X11 things.
    
    this commit also fixes a regression introduced in b2d4358. because we
    pull the event out now, the DestroyNotify event won't stick around in
    the queue anymore.
    
    Fixes: resurrecting-open-source-projects#319
    N-R-K committed May 25, 2023
    Configuration menu
    Copy the full SHA
    904c29f View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Configuration menu
    Copy the full SHA
    9334ca0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23ce12a View commit details
    Browse the repository at this point in the history