Migrate source code to python 3.7 and refine code style #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The django.core.urlresolvers module is removed in favor of its new location, django.urls. The on_delete argument for ForeignKey and OneToOneField is required in models and migrations.
Migrate to python3 and django 2.x
Update template of settings.py
Fix on_delete of ForeignKey and OneToOneField for migrations
|
@retspen may be we can accept it as a new branch like version 1.5 |
|
It is huge update I think. We have to test qualitatively. If will be no problems I will merge the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of python/devguide#344 there will be no support for python2 anymore after 2020. Can you migrate the source code to python3?