Skip to content

Commit

Permalink
chore: pin github workflows to specific ubuntu versions (#293)
Browse files Browse the repository at this point in the history
With exception of the native Linux x86_64 release build, all workflows use an `ubuntu-22.04` runner. We're intentionally pinning the native release build to `ubuntu-22.04` for wider compatibility of the produced binaries.
  • Loading branch information
reubeno authored Dec 16, 2024
1 parent 0f646de commit 035ef83
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-reports.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
jobs:
report:
name: "Report"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Find workflow run
id: find-run
Expand Down
22 changes: 13 additions & 9 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ jobs:
matrix:
include:
# Build for x86_64/linux target on native host.
- host: "ubuntu-latest"
# N.B. We intentionally pin to Ubuntu 22.04 for now to increase
# the range of distros that will be able to run the produced binaries.
# Newer release of Ubuntu upgrade glibc to a point not yet supported
# by some latest stable versions of distros.
- host: "ubuntu-22.04"
target: ""
os: "linux"
arch: "x86_64"
Expand All @@ -45,23 +49,23 @@ jobs:
binary_name: "brush"
extra_build_args: ""
# Build for aarch64/linux target on x86_64/linux host.
- host: "ubuntu-latest"
- host: "ubuntu-24.04"
target: "aarch64-unknown-linux-gnu"
os: "linux"
arch: "aarch64"
required_tools: "gcc-aarch64-linux-gnu"
binary_name: "brush"
extra_build_args: ""
# Build for WASI-0.2 target on x86_64/linux host.
- host: "ubuntu-latest"
- host: "ubuntu-24.04"
target: "wasm32-wasip2"
os: "wasi-0.2"
arch: "wasm32"
required_tools: ""
binary_name: "brush.wasm"
extra_build_args: "--no-default-features --features minimal"
# Build for x86_64/windows target on x86_64/linux host.
- host: "ubuntu-latest"
- host: "ubuntu-24.04"
target: "x86_64-pc-windows-gnu"
os: "windows"
arch: "x86_64"
Expand Down Expand Up @@ -125,7 +129,7 @@ jobs:
fail-fast: false
matrix:
include:
- host: "ubuntu-latest"
- host: "ubuntu-24.04"
variant: "linux"
artifact_suffix: ""
name_suffix: "(linux)"
Expand Down Expand Up @@ -241,7 +245,7 @@ jobs:
# Static analysis of the code.
check:
name: "Source code checks"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

strategy:
matrix:
Expand Down Expand Up @@ -285,7 +289,7 @@ jobs:
# Check for unneeded dependencies.
check-deps:
name: "Check for unneeded dependencies"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -307,7 +311,7 @@ jobs:
benchmark:
if: github.event_name == 'pull_request'
name: "Benchmarks"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -371,7 +375,7 @@ jobs:
prereqs_command: "pacman -Sy --noconfirm bash-completion iputils grep less sed util-linux"

name: "OS target tests (${{ matrix.description }})"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
container: ${{ matrix.container }}
needs: build
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/devcontainer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
jobs:
build:
name: "Build devcontainer"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions:
contents: read
packages: read
Expand All @@ -35,7 +35,7 @@ jobs:

build_and_publish:
name: "Build and publish devcontainer"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions:
contents: read
packages: write
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
# Check links in docs
check-links:
name: "Check links"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout sources
uses: actions/checkout@v4
Expand All @@ -30,7 +30,7 @@ jobs:
# Generate docs content
generate-docs:
name: "Generate usage docs"
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down

0 comments on commit 035ef83

Please sign in to comment.